| title: | Re GIT PULL PCI fixes for 2 6 29 |
|
On Wed, Mar 11, 2009 at 12:22:56PM -0700, Linus Torvalds wrote:
On Tue, 10 Mar 2009, Matthew Wilcox wrote:
These are the PCI fixes that have been piling up for the last week while
Jesses been on vacation. I dont think theres anything questionable
here. All the patches have been posted to linux-pci.
Grrr. It doesnt even compile cleanly:
drivers/pci/quirks.c: In function ?ht_check_msi_mapping?:
drivers/pci/quirks.c:2142: warning: ?return? with no value, in function returning non-void
and yes, its a real bug.
Agreed, its a real bug. I also think it should return 0, but I want
Prakash to verify that, since I dont have a system of this nature.
I wish this warning were an error. According to the GCC docs,
-Werror=return-type should do this, but it seems to have no effect.
Im not happy.
Me neither. Im sorry I didnt catch the warning.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that youre interested in selling us this
operating system, but compare it to ours. We cant possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at rel="nofollow" vger.kernel.org/majordomo-info.html vger.kernel.org/majordomo-info.html
|